- Notifications
You must be signed in to change notification settings - Fork3.8k
feat: add incident.io support to am config secret#8190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
| returnrc.HTTPConfig.sanitize(amVersion,logger) | ||
| } | ||
| func (ic*incidentioConfig)sanitize(amVersion semver.Version,logger*slog.Logger)error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
can we validate URLs too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
hi could you pls clarify, since for this config I added both URL and URL file and have the check for enforcing one's configured, followinghttps://github.com/prometheus/alertmanager/blob/main/config/notifiers.go#L607.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
sorry for being dense, I meant that we can validate that the URL value is valid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ahhhh sorry, do you meant with ValidateURL? added that let me know if that or if I misunderstood. thanks
Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>
Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>
308e07f to462cea5Compare
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
Closes: #ISSUE-NUMBER
If you're contributing for the first-time, check ourcontribution guidelines.
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check thePrometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.