Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add docker ecosystems in dependabot#8100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
dongjiang1989 wants to merge3 commits intoprometheus-operator:main
base:main
Choose a base branch
Loading
fromkubeservice-stack:add-docker-ecosystems

Conversation

@dongjiang1989
Copy link
Member

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.

If it fixes an existing issue (bug or feature), use the following keyword:

Closes: #ISSUE-NUMBER

Type of change

What type of changes does your code introduce to the Prometheus operator? Put anx in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check thePrometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

NONE

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@simonpasquier
Copy link
Contributor

@dongjiang1989 do you know what do we get if we enable the Docker integration in dependabot?

dongjiang1989 reacted with rocket emojidongjiang1989 reacted with eyes emoji

@dongjiang1989
Copy link
MemberAuthor

do you know what do we get if we enable the Docker integration in dependabot?

Thanks@simonpasquier
Detect the base image in the FROM instruction of the Dockerfile and update it to the latest available version.

Like:https://github.com/kubeservice-stack/echo/pull/73/files

Copy link
Contributor

@slashpaislashpai left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

one thing to note is we may not switch to new go versions soon its available so I am not sure if this will cause issues

An example from metrics-serverkubernetes-sigs/metrics-server#1719 (comment)

@dongjiang1989
Copy link
MemberAuthor

one thing to note is we may not switch to new go versions soon its available so I am not sure if this will cause issues

An example from metrics-serverkubernetes-sigs/metrics-server#1719 (comment)

Got it.
There is a possibility of this issue, but the operator does not directly rely on the golang version. Instead, it depends onquay.io/prometheus/golang-builder andquay.io/prometheus/busybox-${os}-${arch}

@slashpai
Copy link
Contributor

one thing to note is we may not switch to new go versions soon its available so I am not sure if this will cause issues
An example from metrics-serverkubernetes-sigs/metrics-server#1719 (comment)

Got it. There is a possibility of this issue, but the operator does not directly rely on the golang version. Instead, it depends onquay.io/prometheus/golang-builder andquay.io/prometheus/busybox-${os}-${arch}

Wont this cause confusion then having different version in Dockerfile?

dongjiang1989 reacted with eyes emoji

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@dongjiang1989
Copy link
MemberAuthor

Wont this cause confusion then having different version in Dockerfile?

Thanks@slashpai
Got it.
Add group for prometheus images together

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@slashpaislashpaislashpai left review comments

+1 more reviewer

@heliapbheliapbheliapb approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dongjiang1989@simonpasquier@slashpai@heliapb

[8]ページ先頭

©2009-2025 Movatter.jp