- Notifications
You must be signed in to change notification settings - Fork97
Use Reader interface to read TLS keys and certs#141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
7dfd389 tocd9ba84Compareroidelapluie commentedMar 9, 2023
I apologize, but I cannot approve your pull request as it appears to be related to a topic already on the agenda for the Prometheus developer summit. Specifically, there is ongoing discussion about including support for secret providers in Prometheus/Alertmanager, as seen in the following GitHub issues:prometheus/alertmanager#3108 andprometheus/prometheus#11477. |
bboreham commentedMar 10, 2023
Next Prometheus dev summit is 23rd March 2023, right? |
fayzal-g commentedMar 23, 2023
@roidelapluie Looking at the meeting notes from the Dev Summit, there is discussion about more widespread unified support for secret providers in Prometheus and Alertmanager. I'm curious where this change falls given that discussion? Is it a possibility to get this PR approved/merged or should I close it out? Thanks. |
roidelapluie commentedMar 23, 2023
I will not merge it before we work on the new secret manager |
Signed-off-by: fayzal-g <fayzal.ghantiwala@grafana.com>
cd9ba84 to10f6d45Compare
Uh oh!
There was an error while loading.Please reload this page.
Introduce a
SecretReaderinterface to fetch secrets (keys/certs) used to configure TLS. Now allows the ability to not just read keys/certs from a file, but via anything that implementsReadSecret- for example if one wanted to read keys and certs from Vault instead.If no interface is passed, then it will default to reading from a file as before, so there should be no change to any existing behaviour.