- Notifications
You must be signed in to change notification settings - Fork338
Add pre-allocation to EscapeMetricFamily#828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
boekkooi-impossiblecloud wants to merge2 commits intoprometheus:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Add pre-allocation to EscapeMetricFamily#828
boekkooi-impossiblecloud wants to merge2 commits intoprometheus:mainfromboekkooi-impossiblecloud:pre-allocate
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
8c1f9c2 to18c2da5CompareSigned-off-by: warnar boekkooi <wboekkooi@impossiblecloud.com>
Signed-off-by: warnar boekkooi <wboekkooi@impossiblecloud.com>
18c2da5 toe1f4baeCompareAuthor
boekkooi-impossiblecloud commentedSep 5, 2025
Hello@roidelapluie,@gotjosh,@ArthurSens, Would one of you maybe have time to review this PR? Thanks in advance and have a great day! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
While I was checking some profiles I noticed that
EscapeNameandEscapeMetricFamilywhere doing a lot of allocation.This PR reduce this a little by pre-allocating the
MetricandLabelslices and the string builder for theUnderscoreEscapingstrategy inEscapeName.Thanks for reviewing and let me know what you think.
Have a good one!