Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

kwok and perf updates#695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
jbusche wants to merge2 commits intoproject-codeflare:main
base:main
Choose a base branch
Loading
fromjbusche:jbusche-perf-improvements

Conversation

@jbusche
Copy link
Contributor

Issue link

#625

What changes have been made

  • Fixed the KWOK install instructions to the latest (easier) method
  • Fixed the Items problem so that appwrappers launch
  • Changed to a while loop that allows as few as 1 appwrapper or fake node to work now (didn't work before with the for loop)

Verification steps

Testing both from a MAC and on my OpenShift cluster

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Signed-off-by: James Busche <jbusche@us.ibm.com>
@openshift-ci
Copy link

[APPROVALNOTIFIER] This PR isNOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assignmetalcycling for approval. For more information seethe Kubernetes Code Review Process.

The full list of commands accepted by this bot can be foundhere.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing/approve in a comment
Approvers can cancel approval by writing/approve cancel in a comment

@jbusche
Copy link
ContributorAuthor

/retest

Signed-off-by: James Busche <jbusche@us.ibm.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ChristianZaccariaChristianZaccariaAwaiting requested review from ChristianZaccaria

@metalcyclingmetalcyclingAwaiting requested review from metalcycling

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jbusche
[8]ページ先頭
©2009-2025 Movatter.jp