Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add histogram metrics of the requested resources#676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ronensc wants to merge1 commit intoproject-codeflare:main
base:main
Choose a base branch
Loading
fromronensc:metrics-requested-resources

Conversation

@ronensc
Copy link

Issue link

What changes have been made

This PR adds custom histogram metrics of a of the requested resources (CPU, Memory and GPU) by the AppWrappers.

Verification steps

Like in#651 and#675, I checked that the metrics are available in the codeflare-operator operator by running it:

# in codeflare-operator rootgo mod edit -replace github.com/project-codeflare/multi-cluster-app-dispatcher=../multi-cluster-app-dispatchermake buildNAMESPACE=default go run ./main.go -kubeconfig <path-to-kubeconfig>

and in a new shell:

curl localhost:8080/metrics | grep mcad_requested# HELP mcad_requested_cpu Histogram of requested CPU (in millicores)# TYPE mcad_requested_cpu histogrammcad_requested_cpu_bucket{le="100"} 0mcad_requested_cpu_bucket{le="200"} 0mcad_requested_cpu_bucket{le="500"} 0mcad_requested_cpu_bucket{le="1000"} 0mcad_requested_cpu_bucket{le="2000"} 0mcad_requested_cpu_bucket{le="5000"} 0mcad_requested_cpu_bucket{le="10000"} 0mcad_requested_cpu_bucket{le="+Inf"} 0mcad_requested_cpu_sum 0mcad_requested_cpu_count 0# HELP mcad_requested_gpu Histogram of requested GPU# TYPE mcad_requested_gpu histogrammcad_requested_gpu_bucket{le="1"} 0mcad_requested_gpu_bucket{le="2"} 0mcad_requested_gpu_bucket{le="4"} 0mcad_requested_gpu_bucket{le="8"} 0mcad_requested_gpu_bucket{le="16"} 0mcad_requested_gpu_bucket{le="32"} 0mcad_requested_gpu_bucket{le="64"} 0mcad_requested_gpu_bucket{le="128"} 0mcad_requested_gpu_bucket{le="256"} 0mcad_requested_gpu_bucket{le="512"} 0mcad_requested_gpu_bucket{le="+Inf"} 0mcad_requested_gpu_sum 0mcad_requested_gpu_count 0# HELP mcad_requested_memory_bytes Histogram of requested memory# TYPE mcad_requested_memory_bytes histogrammcad_requested_memory_bytes_bucket{le="1.34217728e+08"} 0mcad_requested_memory_bytes_bucket{le="2.68435456e+08"} 0mcad_requested_memory_bytes_bucket{le="5.36870912e+08"} 0mcad_requested_memory_bytes_bucket{le="1.073741824e+09"} 0mcad_requested_memory_bytes_bucket{le="2.147483648e+09"} 0mcad_requested_memory_bytes_bucket{le="4.294967296e+09"} 0mcad_requested_memory_bytes_bucket{le="8.589934592e+09"} 0mcad_requested_memory_bytes_bucket{le="1.7179869184e+10"} 0mcad_requested_memory_bytes_bucket{le="3.4359738368e+10"} 0mcad_requested_memory_bytes_bucket{le="6.8719476736e+10"} 0mcad_requested_memory_bytes_bucket{le="+Inf"} 0mcad_requested_memory_bytes_sum 0mcad_requested_memory_bytes_count 0

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci
Copy link

[APPROVALNOTIFIER] This PR isNOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assignanishasthana for approval. For more information seethe Kubernetes Code Review Process.

The full list of commands accepted by this bot can be foundhere.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing/approve in a comment
Approvers can cancel approval by writing/approve cancel in a comment

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dimakisdimakisAwaiting requested review from dimakis

@sutaakarsutaakarAwaiting requested review from sutaakar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ronensc

[8]ページ先頭

©2009-2025 Movatter.jp