Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

MCAD deployment in custom namespace#656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
metalcycling wants to merge1 commit intoproject-codeflare:main
base:main
Choose a base branch
Loading
frommetalcycling:custom-namespace

Conversation

@metalcycling
Copy link
Collaborator

What changes have been made

Installing MCAD always happens in thekube-system namespace. This update allows users to specify the namespace they want to use for the deployment.

Verification steps

Create a namespace calledmcad and deployed MCAD there using thehelm chart and--set namespace="mcad".

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci
Copy link

[APPROVALNOTIFIER] This PR isNOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval frommetalcycling. For more information seethe Kubernetes Code Review Process.

The full list of commands accepted by this bot can be foundhere.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing/approve in a comment
Approvers can cancel approval by writing/approve cancel in a comment

@VanillaSpoon
Copy link
Contributor

/lgtm

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@astefanuttiastefanuttiAwaiting requested review from astefanutti

@asm582asm582Awaiting requested review from asm582

@dmatch01dmatch01Awaiting requested review from dmatch01

@tardieutardieuAwaiting requested review from tardieu

Assignees

@VanillaSpoonVanillaSpoon

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@metalcycling@VanillaSpoon
[8]ページ先頭
©2009-2025 Movatter.jp