- Notifications
You must be signed in to change notification settings - Fork195
fix broken links on contribute sections#956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
junseok44 wants to merge4 commits intoprocessing:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
fix broken links on contribute sections#956
junseok44 wants to merge4 commits intoprocessing:mainfromjunseok44:fix-markdown-relative-links-support
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Extend rewriteRelativeMdLinks to handle reference link syntax- Support both inline links and reference links for markdown files- Maintain backward compatibility with existing inline link processing
- Replace endsWith() with includes() to detect .md files with hash fragments- Use lookahead regex to avoid breaking .mdx and other extensions- Properly convert links like 'file.md#section' to 'file/#section'
- Add comprehensive test for reference link syntax processing- Verify both inline and reference links are handled correctly- Test hash fragment preservation in reference links
lirenjie95 approved these changesSep 28, 2025
Contributor
lirenjie95 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank for provide the fix and related unit test!
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Related to#527
This PR resolves broken links on:
https://p5js.org/contribute/friendly_error_system/
https://p5js.org/contribute/steward_guidelines/
What this PR does
rewriteRelativeMdLinksfunction which previously only handled inline links but not reference-style markdown linksinlineLinkRegexPatternto accurately describe what it captures.mdextension wasn't being removed from relative links when followed by hash fragments (e.g.,file.md#section)What this PR does not address
[Issues](steward_guidelines.md#issues)) still result in incorrect URLs due to the../prefix being added by existing logic. These were already broken before this PR._fesErrorMonitor()] on the friendly error system page is a typo in the source documentation from the p5.js repository. This will be addressed in a separate PR to the main p5.js repo.