Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[GSOC 2025]: Github action for translation tracker#895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Divyansh013 wants to merge22 commits intoprocessing:main
base:main
Choose a base branch
Loading
fromDivyansh013:week2

Conversation

@Divyansh013
Copy link
Member

@Divyansh013Divyansh013 commentedJul 6, 2025
edited
Loading

  • test-local file detects local changes
  • index.js does manual triggering for issue creation
  • action works on all "push" events
  • outdated banner addition on missing translation pages

- Updated translation-sync workflow for examples instead of reference- Added Week 3 test change to Shape Primitives description- Should trigger automated issue creation for outdated translations
- Added workflow_dispatch with scan_all and create_issues options- Can now manually trigger action from GitHub UI- Supports both normal and full-scan modes
- Modified description.mdx to test translation tracker- Should now detect 1 English example file change
- test-local.js: Only shows changed files from predefined test files- index.js: Production mode with minimal console output- Removed verbose logging and repository exploration- Clear distinction: test mode vs production mode with GitHub token
- SCAN_ALL=true environment variable to check all 61 example files- Simplified GitHub Actions workflow- Default: checks only changed files- Manual trigger: option to scan all files
@ksen0
Copy link
Member

Hi@Divyansh013 , this is looking great!

Based on checking the current issue created by this (Divyansh013#11) I have a couple of minor suggestions:

  • Move🔍 Compare changes to the Quick Links section, because it's not file-specific.
  • Potentially: next to thisone link to "Compare changes", could add a note like:ℹ️ You can see the changes in a specific file by going the the "Compare changes" link above, clicking on the "Files changed" tab, and navigating to the specific file.
  • Move "Change Type: English file was updated. Spanish (Español), Hindi (हिन्दी), Korean (한국어), Chinese Simplified (简体中文) translations may be outdated." into the Timeline - right now this is very far separated, but seems related?
Divyansh013 reacted with thumbs up emoji

@Divyansh013Divyansh013 marked this pull request as ready for reviewAugust 18, 2025 05:10
@Divyansh013
Copy link
MemberAuthor

@ksen0 requesting your review here

@Divyansh013Divyansh013 changed the titleBasic functionality of translation tracker[GSOC 2025]: Github actions for translation trackerAug 18, 2025
@Divyansh013Divyansh013 changed the title[GSOC 2025]: Github actions for translation tracker[GSOC 2025]: Github action for translation trackerAug 18, 2025
contribute:'अनुवाद में योगदान दें',
},
'es': {
title:'Esta traducción podría estar desactualizada',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi@marioguzzzman! If/when you have time, could you check these Spanish translations please? Thanks so much!

Divyansh013 reacted with heart emoji
Copy link

@marioguzzzmanmarioguzzzmanOct 14, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The grammatically correct way would be to say "Ver la versión en inglés" but I think it works better and is more clean for an internet use context to leave it like: "Ver versión en inglés". So I would say the translation works correctly@ksen0!

ksen0 reacted with heart emoji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

let englishUrl=Astro.url.pathname;
if (currentLocale!=='en') {
// Replace /{locale}/ with / to get English URL
englishUrl=englishUrl.replace(`/${currentLocale}/`,'/');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Question here: have you tried usingzh-Hans? It is a different use case fromes,hi andko. I’m wondering if the replace operation will succeed.
PS: Please check all places withcurrentLocale andreplace()

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes have checked zh-Hans and it is working in expected way. I will check in all places

lirenjie95 and ksen0 reacted with thumbs up emoji
-Links to files and comparisons
-Action checklist for translators
-Proper labels (`needs translation`, `lang-es`, etc.)
4. **Generates** manifest file for website banner system
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks so much for the README updates! As one last thing, please include here or ~line 112 a short explanation/example of thetranslation-status format.

constenglishCommit=commitInfo.english;
consttranslationCommit=commitInfo.translation;

return`## 🌍 Translation Update Needed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

As a future improvement, this could be pulled out as a template file separate form the .js script.


on:
push:
branches:[main, week2]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is looking great and nearly ready for further testing. If we're now in step 1 of the below iterative deployment process, then to get to step 2, I think this should listen for push on branchonly for now

  1. Finalize this PR tested on your fork, document any further improvements, etc.
  2. create a new PR that contains only the action. This PR would target the main branch, but the action would listen for translation changes on the staging branch.
  3. create a PR that targets the staging branch to add the UI. This will allow fine-tuning the tool.
  4. Lastly, to make it go live, the process would be to marge the UI PR into main, and then change the action to listen on main rather than branch

examples,
};
fs.writeFileSync(manifestPath,JSON.stringify(manifest,null,2),'utf8');
console.log(`\n🗂️ Wrote translation manifest:${manifestPath}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Include current directory in output

Divyansh013 reacted with thumbs up emoji
on:
push:
branches:[main, week2]
paths:['src/content/examples/en/**']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This already looks generalized, which is great

Divyansh013 reacted with heart emoji
console.log('DEBUG: Current locale:',currentLocale);
try {
const manifestPath=path.join(process.cwd(),"public","translation-status","examples.json");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think at this stage, it makes sense to keep this here, but in the future (or now, optionally, if you prefer) also generalize it as a component usable in other layouts.

Divyansh013 reacted with thumbs up emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ksen0ksen0Awaiting requested review from ksen0

2 more reviewers

@marioguzzzmanmarioguzzzmanmarioguzzzman left review comments

@lirenjie95lirenjie95lirenjie95 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Divyansh013@ksen0@marioguzzzman@lirenjie95

[8]ページ先頭

©2009-2025 Movatter.jp