Movatterモバイル変換

Skip to content

processing/p5.jsPublic

NotificationsYou must be signed in to change notification settings
Fork3.7k
Star23.3k

Fix setHeading behavior for non-2D p5.Vector instances#8330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open

aashu2006 wants to merge1 commit intoprocessing:main

base:main

Choose a base branch

fromaashu2006:branch_akshat

Open

Fix setHeading behavior for non-2D p5.Vector instances#8330

aashu2006 wants to merge1 commit intoprocessing:mainfromaashu2006:branch_akshat

+17 −0

Conversation

@aashu2006

Copy link

aashu2006 commentedDec 15, 2025•
edited
Loading

Resolves#8215

Changes:

Restrictp5.Vector.prototype.setHeading() to vectors with a zero or undefined z component.
Throw an error whensetHeading() is called on vectors with a non-zero z value.
Added unit tests to cover invalid-dimension behavior.

Screenshots of the change:
N/A (non-visual change)

PR Checklist

npm run lint passes
[Inline reference] is included / updated
[Unit tests] are included / updated

@aashu2006

Restrict setHeading to vectors with zero or undefined z

5ed6034

@aashu2006

Copy link

Author

aashu2006 commentedDec 15, 2025

Happy to adjust this if a different error behavior or messaging is preferred.

@aashu2006

aashu2006 mentioned this pull request

[2.x] Fix dimensional quirk in thesetHeading() method ofp5.Vector#8215

Open

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

None yet

1 participant

@aashu2006

[8]ページ先頭

©2009-2025 Movatter.jp