🎉 Thanks for opening this pull request! For guidance on contributing, check out ourcontributor guidelines and otherresources for contributors!
🤔 Please ensure that your PR links to an issue, which has been approved for work by a maintainer; otherwise, there might already be someone working on it, or still ongoing discussion about implementation. You are welcome to join the discussion in an Issue if you're not sure!
🌸 Once your PR is merged, be sure toadd yourself to thelist of contributors on the readme page !

Thank You!

Rebasing this PR onto the latest dev-2.0.
I’ve re-tested the fix locally using the built lib/p5.js, and the ortho Camera.slerp() issue is resolved.

Hi@nakednous, sorry for the delay on this! I think this approach works, but it might be for the best to not allow these to be settable for safety?@holomorfo@limzykenneth do you have thoughts?

If we don't want to let those properties be settable, rather than cloning + updating the existing matrix here:

...maybe we just set the state directly to a clone of the camera's matrix?

I double-checked this locally and can confirm both variants remove the orthoslerp() crash:

if(this._isActive()){this._renderer.states.setValue('uPMatrix',this._renderer.states.uPMatrix.clone());}

and

if(this._isActive()){this._renderer.states.setValue('uPMatrix',this._renderer.states.uPMatrix.clone());constdst=this._renderer.states.uPMatrix.mat4;constsrc=this.projMatrix.mat4;for(leti=0;i<dst.length;i++){dst[i]=src[i];}}

In the minimal test sketch I used, the ortho projection parameters ofcam0 andcam1 are identical, so simply cloninguPMatrix is sufficient to avoid the crash. However, the second version preserves the intended behavior of propagating interpolated ortho projection changes (when they differ) without assigning tomat4, keeping it getter-only.

Happy to go with whichever direction you prefer.

Thanks for taking a look! Have you tried if something like this works?

this._renderer.states.setValue('uPMatrix',this.projMatrix.clone());

This would be directly creating a clone of the intended matrix rather than cloning the renderer's matrix and updating it, since the result in both cases is a new matrix with the intended values.