Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.7k
feat(typography): add JUSTIFIED horizontal alignment for bounded text in 2D renderer#8294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Vansh0204 wants to merge4 commits intoprocessing:mainChoose a base branch fromVansh0204:feat/justified-align-pr1
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+212 −2
Open
Changes from1 commit
Commits
Show all changes
4 commits Select commitHold shift + click to select a range
05aa09a feat(typography): add JUSTIFIED alignment for bounded text in 2D rend…
Vansh0204881635f test(visual): add JUSTIFIED alignment and wrap cases to typography vi…
Vansh0204a3b87cb Add PRETTY/BALANCE constants and manual tests for textWrap/textAlign
Vansh02041b043d9 Fix: Use uppercase values for PRETTY/BALANCE constants per naming con…
Vansh0204File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
NextNext commit
feat(typography): add JUSTIFIED alignment for bounded text in 2D rend…
…erer- Justifies non-final lines in bounded text()- Keeps final line ragged- Maps Canvas2D textAlign to LEFT when JUSTIFIED is set- WEBGL remains left-aligned for nowRefs#7712
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit05aa09ae48f8fe43f7198a1fdb7e4cd82a1fcf58
There are no files selected for viewing
1 change: 1 addition & 0 deletionssrc/core/constants.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletionssrc/core/p5.Renderer.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
41 changes: 39 additions & 2 deletionssrc/core/p5.Renderer2D.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.