Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add keycode fes warning#8238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
a-y-a-n-das wants to merge2 commits intoprocessing:main
base:main
Choose a base branch
Loading
froma-y-a-n-das:add-keycode-fes-warning

Conversation

@a-y-a-n-das
Copy link

Resolves#7876

Changes:

  • Added a one-timeFriendly Error System (FES) warning forkeyCode usage insrc/core/main.js.
    • The warning informs users thatkeyCode is deprecated and suggests usingkeyIsDown() instead.
  • Added amanual test files:test/manual-test-examples/events/keyCode-warning.html andtest/manual-test-examples/events/keyCode-warning-sketch.js
    • Verifies that the warning appears once and key behavior remains unchanged.

Screenshots of the change:

image

PR Checklist

@welcome
Copy link

welcomebot commentedNov 7, 2025

🎉 Thanks for opening this pull request! For guidance on contributing, check out ourcontributor guidelines and otherresources for contributors!
🤔 Please ensure that your PR links to an issue, which has been approved for work by a maintainer; otherwise, there might already be someone working on it, or still ongoing discussion about implementation. You are welcome to join the discussion in an Issue if you're not sure!
🌸 Once your PR is merged, be sure toadd yourself to thelist of contributors on the readme page !

Thank You!

@a-y-a-n-das
Copy link
Author

Hi!
I realized I should’ve claimed this issue first (as per the contributing guidelines), but since it wasn’t assigned to anyone and was still open, I went ahead and fixed it.
Hope that’s okay — please review when you get a chance. I can make any necessary adjustments if needed. 😊

@ksen0ksen0 self-requested a reviewNovember 7, 2025 19:16
@a-y-a-n-das
Copy link
Author

a-y-a-n-das commentedDec 6, 2025•
edited
Loading

@ksen0, let me know if any changes are needed.

a-y-a-n-das reacted with confused emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ksen0ksen0Awaiting requested review from ksen0

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add FES warning for keyCode === usage to help transition from 1.x to 2.0

1 participant

@a-y-a-n-das
[8]ページ先頭
©2009-2025 Movatter.jp