Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.6k
[dev-2.0] style: fix eslint warnings#8055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:dev-2.0
Are you sure you want to change the base?
[dev-2.0] style: fix eslint warnings#8055
Uh oh!
There was an error while loading.Please reload this page.
Conversation
🎉 Thanks for opening this pull request! For guidance on contributing, check out ourcontributor guidelines and otherresources for contributors! Thank You! |
| } | ||
| letoutput='// This file is auto-generated from JSDoc documentation\n\n'; | ||
| output+='declare class p5 {\n'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thequotes rule looks too aggressive...
I think it's okay toallow backticks in any case.
| [ | ||
| "Function", | ||
| "Object?" | ||
| ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
parameterData.json might be out of date. I think it's nice to have a CI that checks parameterData.json is up-to-date.
| constprocessOverload=overload=>{ | ||
| if(overload.params){ | ||
| returnObject.values(overload.params).map(param=>processParam(param)); | ||
| } | ||
| returnoverload; | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ESLint warned thatprocessOverload comes beforeprocessParam, thus it might call uninitialized variable. This is why I moved this code.
Relates#7930 (Maybe?)
Changes:
I fixed ESLint warnings in
utils/**/*.mjs.casebranch which defines variableScreenshots of the change:
N/A
PR Checklist
npm run lintpasses