Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.7k
Framebuffer support on WebGPU renderer#8008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
37 commits Select commitHold shift + click to select a range
ca5f9c6 Refactor framebuffers
davepagurekf94f898 Fix ordering of dirty flag
davepagurek5dfcd24 Make sure textures are cleared at start
davepagurek4fd6c19 Add fixes for other gl-specific cases
davepagurekedce029 Fix canvas readback
davepagurek9fc319f Start adding tests
davepagurek76c0108 Add another test
davepagureka3daa14 Fix main canvas not being drawable after resizing
davepagurek01110c9 Add screenshots
davepagurekda86527 Try setting different launch options
davepagurek02eef85 Test different options
davepagurek3c6c195 Try sequential
davepagureke450957 Attempt to install later chrome
davepagurekf44629b Add some debug info
davepagurekb281d33 Try different flags
davepagurek7773341 Does it work in xvfb?
davepagurekcfeac93 Try enabling swiftshader
davepagurekaf5194a less flags
davepagurek88b4fe4 Try disabling dawn
davepagurekff83226 Try installing swiftshader?
davepagurek4314cf2 Just vulkan
davepagurekc01dee7 Try with xvfb
davepagurek7b3ed67 Test ci flow with warp.
tychedelia22f5294 Fixes for CI.
tychedeliaa8dea15 Revert change.
tychedelia9c49827 Add setAttributes api to WebGPU renderer.
tychedelia695e9e6 Try ignore-blocklist flag
davepagurek48ce320 Go back to ubuntu for now, try different swiftshader flags
davepagurek4753544 Different flag
davepagurek9eb541d Check if the adapter is defined
davepagurek74c1672 Try without setAttributes since the adapter seems to exist before that
davepagurek498bb83 Try installing chrome with swiftshader
davepagurekbc3501a Revert "Try installing chrome with swiftshader"
davepagurek88dec1b Try chrome on windows
davepagurekd5f584f Don't run webgpu tests on CI for now
davepagurek3ea32ed Exclude other webgpu tests
davepagurek724b41a Move setAttributes implementation to renderer
davepagurekFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Attempt to install later chrome
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commite4509570a43e8744ab8ab17e68fc6fd464eed227
There are no files selected for viewing
9 changes: 9 additions & 0 deletions.github/workflows/ci-test.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletiontest/unit/visual/cases/webgpu.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -311,4 +311,4 @@ visualSuite("WebGPU", function () { | ||
| }, | ||
| ); | ||
| }); | ||
| }); | ||
5 changes: 1 addition & 4 deletionstest/unit/visual/visualTest.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletionstest/unit/webgpu/p5.Framebuffer.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
10 changes: 7 additions & 3 deletionsvitest.workspace.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.