Jul 9, 2025 · Jul 7, 2025 · Jul 7, 2025 · Jul 9, 2025 · Jul 9, 2025 · Jul 8, 2025
diff --git a/src/webgl/ShaderGenerator.js b/src/webgl/ShaderGenerator.js
    if (shaderModifier instanceof Function) {
      let generatorFunction;
      if (options.parser) {
        // #7955 Wrap function declaration code in brackets so anonymous functions are not top level statements, which causes an error in acorn when parsing
        // https://github.com/acornjs/acorn/issues/1385
        const sourceString = `(${shaderModifier.toString()})`;
        const ast = parse(sourceString, {
          ecmaVersion: 2021,
Original file line number	Diff line number	Diff line change
Expand Up		@@ -19,6 +19,8 @@ function shadergenerator(p5, fn) {
		if (shaderModifier instanceof Function) {
		let generatorFunction;
		if (options.parser) {
		// #7955 Wrap function declaration code in brackets so anonymous functions are not top level statements, which causes an error in acorn when parsing
		// https://github.com/acornjs/acorn/issues/1385
		const sourceString = `(${shaderModifier.toString()})`;
Copy link Contributor davepagurekJul 8, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Do you mind adding a comment here to explain to other contributors why the brackets are necessary? Copy link Author nking07049925Jul 8, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Would something like this work? `// #7955 Wrap function declaration code in brackets so anonymous functions are not top level statements, which causes an error in acorn when parsing` Copy link Contributor davepagurekJul 8, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. looks great, thanks! Copy link Author nking07049925Jul 8, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Nice! I will be able to make a commit later today davepagurek reacted with heart emoji
		const ast = parse(sourceString, {
		ecmaVersion: 2021,
Expand Down