Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.5k
fix: manual cleanup capability of text and memory #7700#7890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
🎉 Thanks for opening this pull request! Please check out ourcontributing guidelines if you haven't already. And be sure to add yourself to thelist of contributors on the readme page! |
Hi@uppathidev! Currently we're only adding new features to p5 2.x, which is in the |
@@ -455,6 +455,15 @@ p5.Texture = class Texture { | |||
} | |||
}; | |||
// manual cleanup capability | |||
p5.Texture.prototype.free = function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we can just make this method directly in the texture class in this file rather than adding it to the prototype here.
davepagurek commentedJun 11, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Also, some general thoughts:
|
Uh oh!
There was an error while loading.Please reload this page.
Resolves#7700
Changes:FIX: manual cleanup capability of text and memory
Screenshots of the change:
PR Checklist
npm run lint
passes