NotificationsYou must be signed in to change notification settings
Fork3.7k
Star23.3k

Fixed Error in FES prevents message from being shown, Prevented 'window' properties from being overwritten#7765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

davepagurek merged 3 commits intoprocessing:dev-2.0fromHughJacks:fix-fes-error

Apr 22, 2025

Merged

Fixed Error in FES prevents message from being shown, Prevented 'window' properties from being overwritten#7765

davepagurek merged 3 commits intoprocessing:dev-2.0fromHughJacks:fix-fes-error

Apr 22, 2025

Conversation

Copy link

HughJacks commentedApr 21, 2025

Resolves#7678

Changes:

Added a list of protected properties inmain.js to prevent p5 from overriding certain window properties:

Added a check forhasOwnProperty infes_core.js to prevent inherited properties like constructor from causing errors:

Changedcore/main.js from:

// Attach its properties to the windowfor(constpinthis){if(this.hasOwnProperty(p)){if(p[0]==='_')continue;bindGlobal(p);}}

to:

constprotectedProperties=['constructor','length'];// Attach its properties to the windowfor(constpinthis){if(this.hasOwnProperty(p)){if(p[0]==='_'||protectedProperties.includes(p))continue;bindGlobal(p);}}

Changedcore/friendly_errors/fes_core.js from:

if(fxns.[lowercase]&&!context[fxns[lowercase]]&&typeofcontext[prop]==='function'){

to:

if(fxns.hasOwnProperty(lowercase)&&!context[fxns[lowercase]]&&typeofcontext[prop]==='function'){

Screenshots of the change:

PR Checklist

npm run lint passes
Inline reference is included / updated
Unit tests are included / updated

HughJacksand others added3 commits

April 20, 2025 14:11

Added protected properties before second bindGlobal loop, exclude pro…

0b8ff6c

…tected properties from being bound.

test improve

f36587d

Fixed Error in FES prevents message from being shown

a5f0be6

Prevented window.constructor and window.length from being overwritten in bindGlobal

Copy link

welcomebot commentedApr 21, 2025

🎉 Thanks for opening this pull request! Please check out ourcontributing guidelines if you haven't already. And be sure to add yourself to thelist of contributors on the readme page!