Commit4fb55a9

authored

feat(client-engine-runtime): remove outdated comment (#28928)

This PR closes[TML-1572](https://linear.app/prisma-company/issue/TML-1572/timebox-2h-normalize-error-message-in-functionalchunking-queryteststs),which is no longer relevant.The old query engine used to have a generic `Query parameter limitexceeded error: {message}.` error, which a few possible instances ofsaid dynamic `{message}`.`The query parameter limit supported by your database is exceeded.` isthe appropriate message for `js_pg` and `js_cockroachdb` in [thistest](https://github.com/prisma/prisma/blob/b45b2f7345f7158d51f9efe91eb8e732a2f2ec4d/packages/client/tests/functional/chunking-query/tests.ts#L180-L183),and can be found in[`prisma-engines`](https://github.com/search?q=repo%3Aprisma%2Fprisma-engines%20QueryParameterLimitExceeded&type=code)too. This means that we no longer need to "normalize" this errormessage.## Summary by CodeRabbit* **Chores*** Removed internal documentation comment with no impact to functionalityor user experience.<sub>✏️ Tip: You can customize this high-level summary in your reviewsettings.</sub>Co-authored-by: jkomyno <12381818+jkomyno@users.noreply.github.com>

1 parent815ba13 commit4fb55a9Copy full SHA for 4fb55a9

File tree

-2

lines changed

-2

lines changed

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,6 @@ export function renderQuery(`
`30`	`30`	`constchunks=dbQuery.chunkable ?chunkParams(dbQuery.fragments,args,maxChunkSize) :[args]`
`31`	`31`	`returnchunks.map((params)=>{`
`32`	`32`	`if(maxChunkSize!==undefined&&params.length>maxChunkSize){`
`33`		-// TODO: this should probably say something along the lines of `Query parameter limit exceeded error`, like in
`34`		`-// https://github.com/prisma/prisma-engines/blob/9c30299f5a0ea26a96790e13f796dc6094db3173/libs/user-facing-errors/src/query_engine/mod.rs#L276.`
`35`	`33`	`thrownewUserFacingError('The query parameter limit supported by your database is exceeded.','P2029')`
`36`	`34`	`}`
`37`	`35`

Comments

(0)