Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Pass aria-label prop to ActionBar toolbar#6877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
mperrotti wants to merge5 commits intomain
base:main
Choose a base branch
Loading
frommp/actionbar-aria-label

Conversation

mperrotti
Copy link
Contributor

@mperrottimperrotti commentedSep 18, 2025•
edited
Loading

Unblocks broken tests ingithub-ui introduced during Markdown editor redesign implementation.

Changelog

New

Changed

InActionBar,aria-label now gets added to therole="toolbar" element.

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@CopilotCopilotAI review requested due to automatic review settingsSeptember 18, 2025 18:22
@mperrottimperrotti requested a review froma team as acode ownerSeptember 18, 2025 18:22
@changeset-botchangeset-bot
Copy link

changeset-botbot commentedSep 18, 2025•
edited
Loading

🦋 Changeset detected

Latest commit:6383659

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
NameType
@primer/reactPatch
@primer/styled-reactPatch

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR enables proper accessibility labeling for the ActionBar component by passing thearia-label prop to the toolbar element instead of only using it for overflow menu items.

  • Passesaria-label andaria-labelledby props to the toolbar element
  • Fixes variable name confusion between toolbar label and menu item labels
  • Updates Storybook example to demonstrate proper usage

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

FileDescription
packages/react/src/ActionBar/ActionBar.tsxAdds aria-label support to toolbar element and fixes variable naming conflicts
packages/react/src/ActionBar/ActionBar.stories.tsxAdds aria-label example to Storybook playground
.changeset/flat-ears-wink.mdDocuments the change for release notes

@github-actionsGitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using theintegration workflow. Thanks!

@github-actionsgithub-actionsbot added the integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labelSep 18, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@jonrohanjonrohanjonrohan approved these changes

@pksjcepksjcepksjce approved these changes

Assignees

No one assigned

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mperrotti@jonrohan@pksjce
[8]ページ先頭
©2009-2025 Movatter.jp