Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ProgressBar.Item overridesaria-valuemin/aria-valuemax #6286

Open
Assignees
TylerJDev
Labels
bugSomething isn't workingreact
@rwe

Description

@rwe

Description

ProgressBar.Item ignores any providedaria-valuemin/aria-valuemax, setting them to0 and100 respectively; which breaks aria attributes for quantified progress item that isnot a percent — for example "count of things done out of count of things total".

This used to work, but was broken about 9 months ago in#4878 this commit:73312d8

which now splats the constructedariaAttributes over those provided:
https://github.com/primer/react/blob/ff6bf5cbe1b012b87b5b35af45b3e08b32d1df22/packages/react/src/ProgressBar/ProgressBar.tsx#L68C13-L68C27

Steps to reproduce

<ProgressBararia-valuemin={0}aria-valuemax={12}><ProgressBar.Itemaria-valuemin={0}aria-valuemax={12}aria-valuenow={0+3}progress={3/12*100}><ProgressBar.Itemaria-valuemin={0}aria-valuemax={12}aria-valuenow={3+4}progress={4/12*100}></ProgressBar>

The progress bar items are rendered witharia-max={100}

Version

v37.27

Browser

No response

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingreact

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions


    [8]ページ先頭

    ©2009-2025 Movatter.jp