Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

AddisSupported function support for language#17331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fisker merged 14 commits intoprettier:mainfromJounQin:feat/language_isSupported
Apr 14, 2025

Conversation

JounQin
Copy link
Member

@JounQinJounQin commentedApr 9, 2025
edited
Loading

Description

related

un-ts/prettier#347
un-ts/prettier#388

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in thedocs/ directory).
  • (If the change is user-facing) I’ve added my changes tochangelog_unreleased/*/XXXX.md file followingchangelog_unreleased/TEMPLATE.md.
  • I’ve read thecontributing guidelines.

@pkg-pr-newpkg.pr.new
Copy link

pkg-pr-newbot commentedApr 9, 2025
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/prettier@17331

commit:cb89f03

@netlifyNetlify
Copy link

netlifybot commentedApr 9, 2025
edited
Loading

Deploy Preview forprettier ready!

NameLink
🔨 Latest commitcb89f03
🔍 Latest deploy loghttps://app.netlify.com/sites/prettier/deploys/67fc5e827bfebc00087112c1
😎 Deploy Previewhttps://deploy-preview-17331--prettier.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site configuration.

@JounQinJounQinforce-pushed thefeat/language_isSupported branch 2 times, most recently from43538a0 to928c76bCompareApril 9, 2025 05:40
@fisker
Copy link
Member

The implementation looks good.
Can you add changelog and update docs?

JounQin reacted with thumbs up emojiJounQin reacted with rocket emoji

@JounQinJounQinforce-pushed thefeat/language_isSupported branch from9754f40 tob7add34CompareApril 9, 2025 08:16
@JounQin
Copy link
MemberAuthor

The implementation looks good. Can you add changelog and update docs?

Added and updated!

@JounQinJounQinforce-pushed thefeat/language_isSupported branch fromb7add34 to3660125CompareApril 9, 2025 08:22
@fiskerfisker changed the titlefeat: addisSupported function support for languageAddisSupported function support for languageApr 9, 2025
@fisker
Copy link
Member

I'm wondering if we should call this function first. So that we can exclude some files even the file name or extension matches. So we can fix#4547 an exclude specific file likepnpm-lock.yml#14517

To do so, we need to update it to return 3 kinds of values, egtrue(yes, supported),false(no, not supported),undefined (don't care).

Alternativly, we can add a similar functionshouldIgnore(file)

@JounQin
Copy link
MemberAuthor

To do so, we need to update it to return 3 kinds of values, eg true(yes, supported),false(no, not supported), undefined (don't care).

This is dangerous because the plugin author is very likely to returnfalse unexpectedly.

@fisker
Copy link
Member

To do so, we need to update it to return 3 kinds of values, eg true(yes, supported),false(no, not supported), undefined (don't care).

This is dangerous because the plugin author is very likely to returnfalse unexpectedly.

Good point.

Alternativly, we can add a similar function shouldIgnore(file)

Seems a better choice.

@JounQinJounQinforce-pushed thefeat/language_isSupported branch froma15bd00 tod0b60f0CompareApril 10, 2025 14:13
@JounQinJounQinforce-pushed thefeat/language_isSupported branch fromd0b60f0 to92161edCompareApril 13, 2025 13:09
@fiskerfisker marked this pull request as draftApril 14, 2025 00:40
@fiskerfisker marked this pull request as ready for reviewApril 14, 2025 01:15
@fiskerfisker merged commitc93393c intoprettier:mainApr 14, 2025
32 checks passed
@JounQinJounQin deleted the feat/language_isSupported branchApril 14, 2025 01:36
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fiskerfiskerfisker approved these changes

@sosukesuzukisosukesuzukisosukesuzuki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JounQin@fisker@sosukesuzuki

[8]ページ先頭

©2009-2025 Movatter.jp