Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork97
Use generic type for vnode props in renderToReadableStream/renderToPipeableStream#409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
changeset-botbot commentedJan 10, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
🦋 Changeset detectedLatest commit:dd90281 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means?Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Needs changeset |
…peableStream, similar to other render functions
Uh oh!
There was an error while loading.Please reload this page.
2afaf31 intopreactjs:mainUh oh!
There was an error while loading.Please reload this page.
Currently the
vnodeargument for these two functions always defaults toVNode(which defaults toVNode<{}>), this causes issues withsome arguments that are otherwise valid (and run fine, it's purely a TypeScript typecheck issue).https://codesandbox.io/p/devbox/2tk3ws
Using the same fix as3dcf098 for these functions solves it