Commit94d6603

authored

Merge pull request#430 from reteps/main

Fix JSX renderer to correctly render enumerated properties

2 parents99df7ab +13b2dbe commit94d6603Copy full SHA for 94d6603

File tree

+22

-1

lines changed

+22

-1

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,5 @@`
	`1`	`+---`
	`2`	`+'preact-render-to-string':patch`
	`3`	`+---`
	`4`	`+`
	`5`	`+Fix JSX renderer to correctly render enumerated properties`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@`
`50`	`50`	`"test":"oxlint && tsc && npm run test:vitest:run && npm run bench",`
`51`	`51`	`"test:vitest":"vitest",`
`52`	`52`	`"test:vitest:run":"vitest run",`
`53`		`-"format":"prettier src/*/.{d.ts,js} test/*/.js --write",`
	`53`	`+"format":"prettier src/*/.{d.ts,js} test/*/.{js,jsx} --write",`
`54`	`54`	`"prepublishOnly":"npm run build",`
`55`	`55`	`"release":"npm run build && git commit -am $npm_package_version && git tag $npm_package_version && git push && git push --tags && npm publish"`
`56`	`56`	`},`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@ import {`
`9`	`9`	`VOID_ELEMENTS,`
`10`	`10`	`NAMESPACE_REPLACE_REGEX,`
`11`	`11`	`SVG_CAMEL_CASE,`
	`12`	`+HTML_ENUMERATED,`
`12`	`13`	`HTML_LOWER_CASE,`
`13`	`14`	`getContext,`
`14`	`15`	`setDirty,`
`@@ -22,6 +23,7 @@ import { options, Fragment } from 'preact';`
`22`	`23`	`constUNNAMED=[];`
`23`	`24`
`24`	`25`	`constEMPTY_ARR=[];`
	`26`	`+constEMPTY_STR='';`
`25`	`27`
`26`	`28`	`/**`
`27`	`29`	`* Render Preact JSX + Components to a pretty-printed HTML-like string.`
`@@ -254,6 +256,11 @@ function _renderToStringPretty(`
`254`	`256`	`name='http-equiv';`
`255`	`257`	`}elseif(NAMESPACE_REPLACE_REGEX.test(name)){`
`256`	`258`	`name=name.replace(NAMESPACE_REPLACE_REGEX,'$1:$2').toLowerCase();`
	`259`	`+}elseif(`
	`260`	`+(name.at(4)==='-'\|\|HTML_ENUMERATED.has(name))&&`
	`261`	`+v!=null`
	`262`	`+){`
	`263`	`+v=v+EMPTY_STR;`
`257`	`264`	`}elseif(isSvgMode){`
`258`	`265`	`if(SVG_CAMEL_CASE.test(name)){`
`259`	`266`	`name=`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -171,4 +171,13 @@ describe('jsx', () => {`
`171`	`171`	`it('should not render function children',()=>{`
`172`	`172`	`expect(renderJsx(<div>{()=>{}}</div>)).to.equal('<div></div>');`
`173`	`173`	`});`
	`174`	`+`
	`175`	`+it('should render enumerated attributes',()=>{`
	`176`	`+expect(renderJsx(<divdraggable={true}/>)).to.equal(`
	`177`	`+'<div draggable="true"></div>'`
	`178`	`+);`
	`179`	`+expect(renderJsx(<divdraggable={false}/>)).to.equal(`
	`180`	`+'<div draggable="false"></div>'`
	`181`	`+);`
	`182`	`+});`
`174`	`183`	`});`

Comments

(0)