Commit45b8e8b

authored

Optimise perf (#385)

1 parent883e02b commit45b8e8bCopy full SHA for 45b8e8b

File tree

3 files changed

+17

-11

lines changed

3 files changed

+17

-11

lines changed

`‎.changeset/proud-apes-tickle.md‎`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,5 @@`
	`1`	`+---`
	`2`	`+'preact-render-to-string':patch`
	`3`	`+---`
	`4`	`+`
	`5`	`+Improve perf a bit by hoisting the typeof check to reduce calling typeof`

`‎package.json‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@`
`132`	`132`	`"@babel/register":"^7.12.10",`
`133`	`133`	`"@changesets/changelog-github":"^0.4.1",`
`134`	`134`	`"@changesets/cli":"^2.18.0",`
`135`		`-"baseline-rts":"npm:preact-render-to-string@6.5.7",`
	`135`	`+"baseline-rts":"npm:preact-render-to-string@latest",`
`136`	`136`	`"benchmarkjs-pretty":"^2.0.1",`
`137`	`137`	`"chai":"^4.2.0",`
`138`	`138`	`"check-export-map":"^1.3.1",`

`‎src/index.js‎`

Lines changed: 11 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -236,12 +236,11 @@ function _renderToString(`
`236`	`236`	`returnEMPTY_STR;`
`237`	`237`	`}`
`238`	`238`
	`239`	`+letvnodeType=typeofvnode;`
`239`	`240`	`// Text VNodes: escape as HTML`
`240`		`-if(typeofvnode!=='object'){`
`241`		`-if(typeofvnode==='function')returnEMPTY_STR;`
`242`		`-returntypeofvnode==='string'`
`243`		`-?encodeEntities(vnode)`
`244`		`-:vnode+EMPTY_STR;`
	`241`	`+if(vnodeType!=='object'){`
	`242`	`+if(vnodeType==='function')returnEMPTY_STR;`
	`243`	`+returnvnodeType==='string' ?encodeEntities(vnode) :vnode+EMPTY_STR;`
`245`	`244`	`}`
`246`	`245`
`247`	`246`	`// Recurse into children / Arrays`
`@@ -305,7 +304,7 @@ function _renderToString(`
`305`	`304`	`if(typeoftype==='function'){`
`306`	`305`	`if(type===Fragment){`
`307`	`306`	`// Serialized precompiled JSX.`
`308`		`-if(props.tpl){`
	`307`	`+if('tpl'inprops){`
`309`	`308`	`letout=EMPTY_STR;`
`310`	`309`	`for(leti=0;i<props.tpl.length;i++){`
`311`	`310`	`out=out+props.tpl[i];`
`@@ -338,7 +337,7 @@ function _renderToString(`
`338`	`337`	`}`
`339`	`338`
`340`	`339`	`returnout;`
`341`		`-}elseif(props.UNSTABLE_comment){`
	`340`	`+}elseif('UNSTABLE_comment'inprops){`
`342`	`341`	`// Fragments are the least used components of core that's why`
`343`	`342`	`// branching here for comments has the least effect on perf.`
`344`	`343`	`return(`
`@@ -402,7 +401,8 @@ function _renderToString(`
`402`	`401`	`letisTopLevelFragment=`
`403`	`402`	`rendered!=null&&`
`404`	`403`	`rendered.type===Fragment&&`
`405`		`-rendered.key==null;`
	`404`	`+rendered.key==null&&`
	`405`	`+!('tpl'inrendered.props);`
`406`	`406`	`rendered=isTopLevelFragment ?rendered.props.children :rendered;`
`407`	`407`
`408`	`408`	`try{`
`@@ -437,7 +437,8 @@ function _renderToString(`
`437`	`437`	`letisTopLevelFragment=`
`438`	`438`	`rendered!=null&&`
`439`	`439`	`rendered.type===Fragment&&`
`440`		`-rendered.key==null;`
	`440`	`+rendered.key==null&&`
	`441`	`+!('tpl'inrendered.props);`
`441`	`442`	`rendered=isTopLevelFragment ?rendered.props.children :rendered;`
`442`	`443`
`443`	`444`	`str=_renderToString(`
`@@ -467,7 +468,7 @@ function _renderToString(`
`467`	`468`	`rendered!=null&&`
`468`	`469`	`rendered.type===Fragment&&`
`469`	`470`	`rendered.key==null&&`
`470`		`-rendered.props.tpl==null;`
	`471`	`+!('tpl'inrendered.props);`
`471`	`472`	`rendered=isTopLevelFragment ?rendered.props.children :rendered;`
`472`	`473`
`473`	`474`	`try{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit45b8e8b

File tree

3 files changed

3 files changed

`‎.changeset/proud-apes-tickle.md‎`

`‎package.json‎`

`‎src/index.js‎`

0 commit comments