Commit0a698f6

authored

renderToPipeableStream: expose errors through onError, no longer emit un-catchable error event on internal stream (#405)

1 parentc819f51 commit0a698f6Copy full SHA for 0a698f6

File tree

+20

-4

lines changed

+20

-4

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,5 @@`
	`1`	`+---`
	`2`	`+'preact-render-to-string':patch`
	`3`	`+---`
	`4`	`+`
	`5`	`+renderToPipeableStream: expose errors through onError, no longer emit un-catchable error event on internal stream`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ interface RenderToPipeableStreamOptions {`
`8`	`8`	`}`
`9`	`9`
`10`	`10`	`interfacePipeableStream{`
`11`		`-abort:()=>void;`
	`11`	`+abort:(reason?:unknown)=>void;`
`12`	`12`	`pipe:(writable:WritableStream)=>void;`
`13`	`13`	`}`
`14`	`14`

Lines changed: 14 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -44,17 +44,28 @@ export function renderToPipeableStream(vnode, options, context) {`
`44`	`44`	`stream.end();`
`45`	`45`	`})`
`46`	`46`	`.catch((error)=>{`
`47`		`-stream.destroy(error);`
	`47`	`+stream.destroy();`
	`48`	`+if(options.onError){`
	`49`	`+options.onError(error);`
	`50`	`+}else{`
	`51`	`+throwerror;`
	`52`	`+}`
`48`	`53`	`});`
`49`	`54`
`50`	`55`	`Promise.resolve().then(()=>{`
`51`	`56`	`options.onShellReady&&options.onShellReady();`
`52`	`57`	`});`
`53`	`58`
`54`	`59`	`return{`
`55`		`-abort(){`
	`60`	`+/**`
	`61`	`+ *@param {unknown} [reason]`
	`62`	`+ */`
	`63`	`+abort(reason=newError('The render was aborted by the server without a reason.')){`
`56`	`64`	`controller.abort();`
`57`		`-stream.destroy(newError('aborted'));`
	`65`	`+stream.destroy();`
	`66`	`+if(options.onError){`
	`67`	`+options.onError(reason);`
	`68`	`+}`
`58`	`69`	`},`
`59`	`70`	`/**`
`60`	`71`	`*@param {import("stream").Writable} writable`

Comments

(0)