Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add comment-key input#82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@sarayourfriend
Copy link
Contributor

@sarayourfriendsarayourfriend commentedJun 16, 2022•
edited
Loading

Addresses#81 using the suggested implementation.

I'm not totally sure how changes to this are tested, mostly because the CI only runs the action with limited options. Open to recommendations for how to properly test this.

@sarayourfriend
Copy link
ContributorAuthor

@developit any chance this can get feedback sometime?

@sarayourfriend
Copy link
ContributorAuthor

@developit Is it possible this PR could get a review?

Co-authored-by: Bruno Bodian <bacarybruno@gmail.com>
@sarayourfriend
Copy link
ContributorAuthor

@developit Any chance for a review here?

@sarayourfriend
Copy link
ContributorAuthor

Closing this PR to clean up my list of open PRs. Please ping me if you'd like me to reopen the PR.

@sarayourfriendsarayourfriend deleted the add/optional-comment-key branchMarch 26, 2024 04:13
@sarayourfriendsarayourfriend restored the add/optional-comment-key branchSeptember 26, 2024 14:42
@sarayourfriend
Copy link
ContributorAuthor

@JoviDeCroock@rschristian are either of y'all able to review this PR? (Just picking the last couple folks I see reviewing and merging in this repository, hope that's okay)

@rschristian
Copy link
Member

Thanks for the ping, I'll definitely try to take a look. Just need to figure out how to test it.

sarayourfriend and slorber reacted with thumbs up emoji

Copy link
Member

@rschristianrschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me, though if you could add some documentation to the readme for this new option it'd be much appreciated.

Sorry this sat for so long without movement.

@sarayourfriend
Copy link
ContributorAuthor

All good, thanks for the review. I've pushed changes with docs to the README and resolved the merge conflict.

rschristian reacted with heart emoji

@rschristianrschristian merged commitddbf3d9 intopreactjs:masterSep 27, 2024
1 check passed
@sarayourfriendsarayourfriend deleted the add/optional-comment-key branchSeptember 27, 2024 03:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@rschristianrschristianrschristian approved these changes

+2 more reviewers

@bacarybrunobacarybrunobacarybruno left review comments

@slorberslorberslorber requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sarayourfriend@rschristian@slorber@bacarybruno
[8]ページ先頭
©2009-2025 Movatter.jp