Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork931
Julia language: skip startup.jl file#3496
Merged
asottile merged 1 commit intopre-commit:mainfromAug 2, 2025
Merged
Conversation
asottile approved these changesAug 2, 2025
Member
asottile left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
a5fe6c5 intopre-commit:main 28 checks passed
Uh oh!
There was an error while loading.Please reload this page.
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull requestAug 12, 2025
This MR contains the following updates:| Package | Update | Change ||---|---|---|| [pre-commit](https://github.com/pre-commit/pre-commit) | minor | `4.2.0` -> `4.3.0` |MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).**Proposed changes to behavior should be submitted there as MRs.**---### Release Notes<details><summary>pre-commit/pre-commit (pre-commit)</summary>### [`v4.3.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#430---2025-08-09)[Compare Source](pre-commit/pre-commit@v4.2.0...v4.3.0)\==================##### Features- `language: docker` / `language: docker_image`: detect rootless docker. - [#​3446](pre-commit/pre-commit#3446) MR by [@​matthewhughes934](https://github.com/matthewhughes934). - [#​1243](pre-commit/pre-commit#1243) issue by [@​dkolepp](https://github.com/dkolepp).- `language: julia`: avoid `startup.jl` when executing hooks. - [#​3496](pre-commit/pre-commit#3496) MR by [@​ericphanson](https://github.com/ericphanson).- `language: dart`: support latest dart versions which require a higher sdk lower bound. - [#​3507](pre-commit/pre-commit#3507) MR by [@​bc-lee](https://github.com/bc-lee).</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this MR and you won't be reminded about this update again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box---This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS41OC4yIiwidXBkYXRlZEluVmVyIjoiNDEuNTguMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds
--startup-file=noto both invocations of Julia (install & run). The startup file is a Julia script that users can configure to run commands before the start of their Julia session. It is typically used to load developer packages like Revise and not used "in-production". Here when we run our pre-commit hooks we do not want to run the user's startup file which could have dependencies the current environment does not have.Split out from#3494
The first commit fails locally for me, showing that the test is effective:
The second commit is the implementation change which shows that the the fix is effective: