Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork931
Fix language:r hook installation when initiated in RStudio#3389
Merged
asottile merged 1 commit intopre-commit:mainfromJan 20, 2025
Merged
Fix language:r hook installation when initiated in RStudio#3389asottile merged 1 commit intopre-commit:mainfrom
asottile merged 1 commit intopre-commit:mainfrom
Conversation
2cc1a2f toffe1692Compareffe1692 toc2c061cCompareotherwise, installing the hooks when RENV_USER env variable is set (e.g. in RStudio with renv project) will result in executing the installation script in the wrong renv
asottile approved these changesJan 20, 2025
Member
asottile left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
c3125a4 intopre-commit:main 23 checks passed
Uh oh!
There was an error while loading.Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading.Please reload this page.
Closes#3385. The bug is that in
install_environment(), the env patch was not applied in the following snippet:The existing
_execute_vanilla_r_code_as_script()abstracting awaywas only suitable to execute R codeafter the environment has been installed and was for that reason not used when the renv environment was set up initially.
Hence, the approach I took was to factor out
_execute_r()that does 1. and 2. and can be parametrised as far as CLI options passed to R go, so it can be used to create the environment itself (_execute_vanilla_r()) and also later to run R code in it (_execute_r_in_renv(), previously named_execute_vanilla_r_code_as_script()).