Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork931
add warning for deprecated stages values indefault_stages#3313
Conversation
DimitriPapadopoulos commentedOct 14, 2024
I get this warning inCI: Yet running $pre-commit migrate-configConfiguration is already migrated.$ |
asottile commentedOct 14, 2024
obviously you're not using a new enough pre-commit version |
DimitriPapadopoulos commentedOct 14, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
$pre-commit --versionpre-commit 4.0.1$ Could |
asottile commentedOct 14, 2024
show your configuration? |
DimitriPapadopoulos commentedOct 14, 2024
The part that needs to be updated is: default_stages:[commit, push] |
asottile commentedOct 14, 2024
works for me $pre-commit migrate-configConfiguration has been migrated.$git diffdiff --git a/.pre-commit-config.yaml b/.pre-commit-config.yamlindex dd04f38..2835f59 100644--- a/.pre-commit-config.yaml+++ b/.pre-commit-config.yaml@@ -3,7 +3,7 @@ ci: autoupdate_commit_msg: "chore: update pre-commit hooks" autofix_commit_msg: "style: pre-commit fixes" autofix_prs: false-default_stages: [commit, push]+default_stages: [pre-commit, pre-push] default_language_version: python: python3 repos: |
DimitriPapadopoulos commentedOct 14, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
It works on my home computer.$grep default_stages .pre-commit-config.yamldefault_stages: [commit, push]$ $pipx install pre-commit installed package pre-commit 4.0.1, installed using Python 3.10.12 These apps are now globally available - pre-commitdone! ✨ 🌟 ✨$ $pre-commit --versionpre-commit 4.0.1$ $pre-commit migrate-configConfiguration has been migrated.$ $grep default_stages .pre-commit-config.yamldefault_stages: [pre-commit, pre-push]$ I'll retry on my computer at work tomorrow, and let you know. Either I did something wrong, or this an effect of a Linux kernel or system issue that breaks my workstation in very strange ways since it was upgraded from Ubuntu 22.04 to Ubuntu 24.04. |
asottile commentedOct 14, 2024
almost certainly it was an old version of pre-commit |
DimitriPapadopoulos commentedOct 15, 2024
I don't think it is an old version (pre-commit installed with pipx just like at home). Rather, my workstation is plagued by mysterious I/O problems since the Ubuntu 24.04 upgrade, see for exampleprefix-dev/rattler-build#1045 (comment). |
asottile commentedOct 15, 2024
I don't necessarily trust pipx to do what you want personally |
DimitriPapadopoulos commentedNov 10, 2024
My workstation has been reinstalled by IT. I cannot reproduce the issue any more. Sorry about the noise. |

No description provided.