Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork931
Closed
Description
search you tried in the issue tracker
is:issue docker is:open
describe your issue
Developing in a Fedora 40 container on a Fedora 41 host, using Docker-in-Docker such that pre-commit can make use of existing containers for lint tests. It appears that the contents of/proc/1/cgroup has changed:
$ cat /proc/1/cgroup0::/This is in contrast to pre-commit's checks for_is_in_docker() and_get_container_id:
def _is_in_docker() -> bool: try: with open('/proc/1/cgroup', 'rb') as f: return b'docker' in f.read() ...def _get_container_id() -> str: ... with open('/proc/1/cgroup', 'rb') as f: for line in f.readlines(): if line.split(b':')[1] == b'cpuset': return os.path.basename(line.split(b':')[2]).strip().decode() ...It's not clear yet what has changed with/proc/1/cgroup nor what the fix should be.
Host:
$ rpm -qa |grep dockerdocker-ce-cli-27.3.1-1.fc41.x86_64docker-ce-27.3.1-1.fc41.x86_64docker-ce-rootless-extras-27.3.1-1.fc41.x86_64docker-compose-plugin-2.29.7-1.fc41.x86_64docker-buildx-plugin-0.17.1-1.fc41.x86_64Guest:
$ rpm -qa |grep dockerdocker-compose-plugin-2.29.7-1.fc40.x86_64docker-buildx-plugin-0.17.1-1.fc40.x86_64docker-ce-cli-27.3.1-1.fc40.x86_64pre-commit --version
pre-commit 3.8.0
.pre-commit-config.yaml
repos: -repo:localhooks: -id:shfmtname:shfmt# shfmt versions can be found here:# https://hub.docker.com/r/mvdan/shfmt/tagsentry:mvdan/shfmt:v3.8.0language:docker_imagetypes:[shell]args:["-w"]
~/.cache/pre-commit/pre-commit.log (if present)
No response
Metadata
Metadata
Assignees
Labels
No labels