Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: update Peer Dependencies for React#125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
feddyups wants to merge1 commit intopraneshr:master
base:master
Choose a base branch
Loading
fromfeddyups:patch-1

Conversation

@feddyups
Copy link

Update Peer Dependencies for React

Update Peer Dependencies for React
Copy link

@e0nee0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. It would be good to release with this change

feddyups, schmave, kevinmprince, jackw, VoltCruelerz, amneacsu, atreb, Reddine, and putugde reacted with thumbs up emoji
@feddyupsfeddyups changed the titleUpdate Peer Dependencies for Reactchore: update Peer Dependencies for ReactJun 10, 2021
@schmave
Copy link

Tests pass locally when using React 17, though you have to install@wojtekmaj/enzyme-adapter-react-17 as an enzyme adapter in order to get them to work. (Enzyme doesn't yet officially support React 17).

feddyups reacted with thumbs up emoji

@yeikel
Copy link

Hi team,

What is blocking this change?

@kad-stokkt
Copy link

kad-stokkt commentedNov 18, 2021•
edited
Loading

approval as a subtle nudge ;)

kevinmprince reacted with laugh emoji

@iamursky
Copy link

up

@feddyups
Copy link
Author

Is this project still alive? Should we try with a fork or something? Ideally before we move to React 18?

iamursky, plamenkoyovchev, mathgeek12, Allwithyou999, and nagarciah reacted with thumbs up emoji

@plamenkoyovchev
Copy link

Come on guys! Let's merge this thing :) A lot of people need it.

nagarciah reacted with thumbs up emoji

@stsmurf
Copy link

+1

Allwithyou999 reacted with thumbs up emoji

@iamursky
Copy link

+1

@nimesulide
Copy link

@praneshr could you please merge this PR?

nagarciah reacted with thumbs up emoji

@nagarciah
Copy link

Hello@praneshr . I've been using this library with React 17 for months now and I can confirm it works fine. I would be glad to help you if there is still anything missing to merge this PR. How may I help?

trungutt and ozkatz reacted with thumbs up emoji

@nnikitos95
Copy link

Hi, guys, what about merge and closing this issue?

franpeza and msarcev reacted with eyes emoji

@talSofer
Copy link

Hi, any estimation on when this issue will be resolved?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

10 more reviewers

@e0nee0nee0ne approved these changes

@garyantorianogaryantorianogaryantoriano approved these changes

@nimesulidenimesulidenimesulide approved these changes

@michael1997michael1997michael1997 approved these changes

@CruseCtrlCruseCtrlCruseCtrl approved these changes

@Allwithyou999Allwithyou999Allwithyou999 approved these changes

@iamurskyiamurskyiamursky approved these changes

@mathgeek12mathgeek12mathgeek12 approved these changes

@KitaharaMugiroKitaharaMugiroKitaharaMugiro approved these changes

@kad-stokktkad-stokktkad-stokkt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

18 participants

@feddyups@schmave@yeikel@kad-stokkt@iamursky@plamenkoyovchev@stsmurf@nimesulide@nagarciah@nnikitos95@talSofer@e0ne@garyantoriano@michael1997@CruseCtrl@Allwithyou999@mathgeek12@KitaharaMugiro
[8]ページ先頭
©2009-2025 Movatter.jp