- Notifications
You must be signed in to change notification settings - Fork47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Add option to disable colour#146
base:master
Are you sure you want to change the base?
Conversation
ddd68d6 to77601d4CompareFixes#140 |
@sidz thoughts on bumping Symphony console to 5.3 ? If your not a fan I can re write to have 2 options (--colour and --no colour separately) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
IMO we need to support at least 4.4 (LTS). phpmnd doesn't work well with 4.0 and php >= 7.4. But it will be right after we release 2.5. Just would like to merge#145 and we are okay to release 2.5.
Also I'd suggest to not include this feature in 2.5.
Regarding the feature itself:
I'm thinking about removing code highlighter at all and in this case we don't need an additional options.
No description provided.