- Notifications
You must be signed in to change notification settings - Fork33
Support building against VC17 on AMD64#9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
davecramer merged 1 commit intopostgresql-interfaces:mainfromapgrucza:fix/msbuild17-pathMay 28, 2024
Merged
Support building against VC17 on AMD64#9
davecramer merged 1 commit intopostgresql-interfaces:mainfromapgrucza:fix/msbuild17-pathMay 28, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Comment on lines +421 to +422
| # As of Visual Studio 2022 (VC17), MSBuild is 64-bit and so is always in ProgramFiles | ||
| if ($env:PROCESSOR_ARCHITECTURE-eq"x86"-or$toolsver-ge17) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is where the actual fix is.@davecramer let me know if you need more explanation on this fix.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my AMD64 machine, the build script was incorrectly looking for MSBuild 17 under
Program Files (x86). MSBuildchanged to 64-bit in Visual Studio 2022, so it should always be underProgram Files.