Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use WiX 5#66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
davecramer merged 16 commits intopostgresql-interfaces:mainfromchrullrich:msi-wix-5
Oct 14, 2024
Merged

Conversation

chrullrich
Copy link
Contributor

@chrullrichchrullrich commentedOct 11, 2024
edited
Loading

This branches from my other MSI branch. x64 and x86 build and work.

See the README for how to install what bits of WiX are needed.

WiX 5 does not use the file name in the key of the File table by default; I have changed modify_msi.vbs to identify its target files by the component ID instead ... and most recently by the file name itself.

Instead of externally generating it and using it explicitly.
This prevents upgrades from leaving files from the previous versionbehind that are not in the new version.
Use the ODBCDriver element only, without additional Registry settings.This works, although it does not solve the file name issue and thereforestill requires removing the short file names from the File table.It also works for installing the x86 driver on an x64 system. Whether itworks on an x86 system remains unknown.
Tested on Windows 10 x86; the driver installs correctly and worksat first glance (in Access, to be precise). Registry and file systemlook good.The comment saying it "probably would be safe" is probably correct.
According to docs, using Package/@platform "is discouraged". The -archoption also provides the default bitness for components, making theComponent/@win64 attribute unnecessary in single-architecture packages.
This element compiles into approximately the same entries in theUpgrade, CustomAction, and InstallExecuteSequence tables.
I think this was the product code, a long time ago.
By about 20 percent.
@chrullrichchrullrichforce-pushed themsi-wix-5 branch 2 times, most recently from55f8095 to949b668CompareOctober 12, 2024 13:08
Use the FileName column itself instead of the file ID. This is lesssusceptible to changes in file IDs (and component IDs) that may happenwhen relying more on default behaviors in future WiX versions.
This is a preview. It appears to build a working x64 installer; I havetested nothing else yet.
Also, put blame where it belongs, which is Windows Installer. If thiswas a bug in WiX, then the fix would be to enforce 8.3 file names forODBC drivers, and we wouldn't like that very much either, would we?
- Remove most Component elements in favor of naked files- Replace PGFOLDER variable with ProgramFiles6432FolderThe Condition element on Component has become an attribute in WiX 5, andthe combination of preprocessor and component condition (i.e. includea non-x64 condition only in a non-x64 package) to install PGXA only froma package native to the underlying OS does not work anymore. Replace itwith a pure component condition that includes the package architecture.The Template summary property has this information already, but it isnot available from within the installation, and I'm not about to startwriting custom actions.
@chrullrich
Copy link
ContributorAuthor

I don't think there is more that needs to be done here this side of adding the arm64 package.

@chrullrichchrullrich marked this pull request as ready for reviewOctober 12, 2024 13:16
@davecramer
Copy link
Contributor

I just have to now figure out why it fails

@davecramer
Copy link
Contributor

Thanks so much for this!

@chrullrich
Copy link
ContributorAuthor

I just have to now figure out why it fails

I saw that. Have another commit.

@davecramerdavecramer merged commit7da4711 intopostgresql-interfaces:mainOct 14, 2024
1 check passed
@davecramer
Copy link
Contributor

cool, thanks so much

@chrullrichchrullrich mentioned this pull requestOct 14, 2024
@chrullrichchrullrich deleted the msi-wix-5 branchOctober 14, 2024 14:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@chrullrich@davecramer

[8]ページ先頭

©2009-2025 Movatter.jp