- Notifications
You must be signed in to change notification settings - Fork21
Using MODULES for building .so instead of MODULE_big.#12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This is fix of my previous commit1443ae0.PGXS supports two ways of building shared libraries: building an so for eachmodule specified in MODULES and building one big so named MODULE_big for allmodules specified in OBJS. Previously this extension used the latter, but alsospecified MODULES variable for no reason, which is pretty strange. Sinceextension contains just one module, it is sane to use the former. I have removedOBJS variable, but forgot to remove MODULE_big in my previous commit, whichbroke the build, since an empty so was assembled. This commit fixes the issue.Besides, PG_CONFIG var is now consulted for path to pg_config, which allows tobuild extension without pg_config in the PATH.
Looks good to me. Thanks! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is fix of my previous commit1443ae0.
PGXS supports two ways of building shared libraries: building an so for each
module specified in MODULES and building one big so named MODULE_big for all
modules specified in OBJS. Previously this extension used the latter, but also
specified MODULES variable for no reason, which is pretty strange. Since
extension contains just one module, it is sane to use the former. I have removed
OBJS variable, but forgot to remove MODULE_big in my previous commit, which
broke the build, since an empty so was assembled. This commit fixes the issue.
Besides, PG_CONFIG var is now consulted for path to pg_config, which allows to
build extension without pg_config in the PATH.