NotificationsYou must be signed in to change notification settings
Fork23
Star163

Fix build due to new checks in PostgreSQL 16#25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kovdb75 merged 1 commit intomasterfromPGPRO-7397

Nov 18, 2022

Merged

Fix build due to new checks in PostgreSQL 16#25

kovdb75 merged 1 commit intomasterfromPGPRO-7397

Nov 18, 2022

Conversation

Copy link

MarinaPolyakova commentedNov 18, 2022

Due to the commit c8b2ef05f481ef06326d7b9f3eb14b303f215c7e in PostgreSQL 16 the macro PG_DETOAST_DATUM returns a pointer to a varlena structure and the input to the function DatumGetPointer must be of type Datum. So

Use a simple cast instead of the function DatumGetPointer.
In the macro VOPS_TEXT_TILE use the function pg_detoast_datum directly instead of the macro DatumGetTextP. As a result, call the function DatumGetPointer in the macro VOPS_GET_TILE because here the val type is usually Datum.

MarinaPolyakova requested a review fromkovdb75

November 18, 2022 20:05

MarinaPolyakova assignedkovdb75

Nov 18, 2022

Fix build due to new checks in PostgreSQL 16

78e84fd

Due to the commit c8b2ef05f481ef06326d7b9f3eb14b303f215c7e in PostgreSQL 16 themacro PG_DETOAST_DATUM returns a pointer to a varlena structure and the input tothe function DatumGetPointer must be of type Datum. So- Use a simple cast instead of the function DatumGetPointer.- In the macro VOPS_TEXT_TILE use the function pg_detoast_datum directly instead  of the macro DatumGetTextP. As a result, call the function DatumGetPointer in  the macro VOPS_GET_TILE because here the val type is usually Datum.

MarinaPolyakova force-pushed thePGPRO-7397 branch fromce668c0 to78e84fdCompare

November 18, 2022 20:09