- Notifications
You must be signed in to change notification settings - Fork35
Add pg_upgrade option#97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
17fb333 to2654ee1Compare| @@ -127,20 +127,23 @@ def __repr__(self): | |||
| class PostgresNode(object): | |||
| def __init__(self, name=None, port=None, base_dir=None, conn_params: ConnectionParams = ConnectionParams()): | |||
| def __init__(self, name=None, port=None, base_dir=None, conn_params: ConnectionParams = ConnectionParams(), bin_dir=None, prefix=None): | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do you really need to change anything with respect toprefix? It only determines the path to the temporary folders used for running tests. Tests are run with the new node only, not with the old one, so the old node should not need temporary folders (and thus its ownprefix) at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Prefix is used as parameter for this structureself._base_dir = self.os_ops.mkdtemp(prefix=self._prefix or TMP_NODE)
TMP_NODE - is just generated string that hard to read and memorize. Adding the parameter will make tests easer for reading and understanding.
248ced6 to334bb22Compare
No description provided.