NotificationsYou must be signed in to change notification settings
Fork35
Star144

Add pg_probackup plugin#92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

demonolock merged 9 commits intomasterfromadd-pg-probackup-plugin

Jan 18, 2024

Merged

Add pg_probackup plugin#92

demonolock merged 9 commits intomasterfromadd-pg-probackup-plugin

Jan 18, 2024

Conversation

Copy link

Contributor

demonolock commentedNov 9, 2023

No description provided.

demonolock force-pushed theadd-pg-probackup-plugin branch 5 times, most recently from9bb5c24 to03d8f96Compare

November 10, 2023 18:38

demonolock force-pushed theadd-pg-probackup-plugin branch 13 times, most recently fromeda1a5b toa868d71Compare

November 21, 2023 22:14

demonolock requested a review fromasavchkov

November 23, 2023 18:47

asavchkov reviewed

Dec 6, 2023

View reviewed changes

plugins/setup.py Outdated


		setup(
		version='0.0.1',
		name='testgres-pg_probackup2',

Copy link

Contributor

asavchkovDec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This setup.py is in the plugins folder and thus relates to all plugins in the folder (of which there can be many) but it's now written specifically for pg_probackup2. Wouldn't it be better to have here one common setup.py to install all plugins at once and have individual setup.py's inside each plugin folder to allow the user to install them selectively?