NotificationsYou must be signed in to change notification settings
Fork35
Star144

safe_psql() should always raise error on wrong input (issue #52)#53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ildus merged 2 commits intomasterfrommaster_fix_52

Jul 18, 2018

Merged

safe_psql() should always raise error on wrong input (issue #52)#53

ildus merged 2 commits intomasterfrommaster_fix_52

Jul 18, 2018

Conversation

Copy link

Collaborator

funbringer commentedJul 18, 2018

This PR adds**kwargs toPostgresNode.psql() which allows user to set psql's variables before execution. Moreover,PostgresNode.safe_psql() will always enableON_ERROR_STOP, which facilitates error detection in scripts run via-f option.

safe_psql() should always raise error on wrong input (issue#52)

60d4572

funbringer requested a review fromildus

July 18, 2018 10:32

style fixes suggested by@ildus

b9648ee

Copy link

codecov-io commentedJul 18, 2018•
edited
Loading

Codecov Report

Merging#53 intomaster willincrease coverage by<.01%.
The diff coverage is100%.

@@            Coverage Diff             @@##           master      #53      +/-   ##==========================================+ Coverage   97.31%   97.31%   +<.01%==========================================  Files          17       17                Lines        1562     1565       +3     ==========================================+ Hits         1520     1523       +3  Misses         42       42

Impacted Files	Coverage Δ
testgres/node.py	`97.55% <100%> (+0.01%)`	⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update6e303fe...b9648ee. Read thecomment docs.