- Notifications
You must be signed in to change notification settings - Fork35
Synchronous standbys#46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-io commentedJun 1, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #46 +/- ##==========================================+ Coverage 97.12% 97.13% +0.01%========================================== Files 17 18 +1 Lines 1529 1572 +43 ==========================================+ Hits 1485 1527 +42- Misses 44 45 +1
Continue to review full report at Codecov.
|
| @@ -24,3 +24,7 @@ | |||
| get_bin_path, \ | |||
| get_pg_config, \ | |||
| get_pg_version | |||
| from .standby import \ | |||
| First, \ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
IMHO those names are too generic to be exported at top level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think names are ok but should be used with the of module, likestandby.First
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@ildus I agree.
I think we should replace |
Now we could write node.append_conf(synchronous_standby_names=First(1, [standby])) |
| self.standbys = standbys | ||
| def __str__(self): | ||
| return u"{} ({})".format(self.sync_num, u", ".join( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
тут мне кажется лучше добавить ключевое слово first, чтобы было явно
| @@ -24,3 +24,7 @@ | |||
| get_bin_path, \ | |||
| get_pg_config, \ | |||
| get_pg_version | |||
| from .standby import \ | |||
| First, \ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think names are ok but should be used with the of module, likestandby.First
What
A wrapper forsynchronous_standby_names server option.
Usage