Mar 21, 2018 · Mar 13, 2018 · Mar 13, 2018 · Mar 13, 2018 · Mar 20, 2018 · Mar 21, 2018
diff --git a/testgres/consts.py b/testgres/consts.py
 PG_LOG_FILE = "postgresql.log"
 UTILS_LOG_FILE = "utils.log"
 BACKUP_LOG_FILE = "backup.log"

 # default replication slots number
 REPLICATION_SLOTS = 10
diff --git a/testgres/node.py b/testgres/node.py
    RECOVERY_CONF_FILE, \
    PG_LOG_FILE, \
    UTILS_LOG_FILE, \
    PG_PID_FILE
    PG_PID_FILE, \
    REPLICATION_SLOTS

 from .decorators import \
    method_decorator, \
        ).format(conninfo)

        if slot_name:
            line += "primary_slot_name={}".format()
            line += "primary_slot_name={}\n".format()

        self.append_conf(RECOVERY_CONF_FILE, line)

                conf.write(u"fsync = off\n")

            # yapf: disable
            conf.write(u"log_statement = {}\n"
                       u"listen_addresses = '{}'\n"
                       u"port = {}\n".format(log_statement,
                                             self.host,
                                             self.port))
            conf.write(
                u"log_statement = {}\n"
                u"listen_addresses = '{}'\n"
                u"port = {}\n"
                u"max_replication_slots = {}\n".format(log_statement,
                                                       self.host,
                                                       self.port,
                                                       REPLICATION_SLOTS))

            # replication-related settings
            if allow_streaming:
Original file line number	Diff line number	Diff line change
Expand Up		@@ -24,3 +24,6 @@
		PG_LOG_FILE = "postgresql.log"
		UTILS_LOG_FILE = "utils.log"
		BACKUP_LOG_FILE = "backup.log"

		# default replication slots number
		REPLICATION_SLOTS = 10
Original file line number	Diff line number	Diff line change
Expand Up		@@ -32,7 +32,8 @@
		RECOVERY_CONF_FILE, \
		PG_LOG_FILE, \
		UTILS_LOG_FILE, \
		PG_PID_FILE
		PG_PID_FILE, \
		REPLICATION_SLOTS

		from .decorators import \
		method_decorator, \
Expand DownExpand Up		@@ -208,7 +209,7 @@ def _create_recovery_conf(self, username, slot_name=None):
		).format(conninfo)

		if slot_name:
		line += "primary_slot_name={}".format()
		line += "primary_slot_name={}\n".format()

		self.append_conf(RECOVERY_CONF_FILE, line)

Expand DownExpand Up		@@ -343,11 +344,14 @@ def get_auth_method(t):
		conf.write(u"fsync = off\n")

		# yapf: disable
		conf.write(u"log_statement = {}\n"
		u"listen_addresses = '{}'\n"
		u"port = {}\n".format(log_statement,
		self.host,
		self.port))
		conf.write(
		u"log_statement = {}\n"
		u"listen_addresses = '{}'\n"
		u"port = {}\n"
		u"max_replication_slots = {}\n".format(log_statement,
Copy link Collaborator funbringerMar 14, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. IMHO`max_replication_slots` should be placed under`allow_streaming=True`, next to`max_wal_senders` etc. Copy link CollaboratorAuthor zilderMar 20, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Agree as well
		self.host,
		self.port,
		REPLICATION_SLOTS))

		# replication-related settings
		if allow_streaming:
Expand Down