- Notifications
You must be signed in to change notification settings - Fork35
Simplified enums#33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks! I think we should keep |
codecov-io commentedFeb 14, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #33 +/- ##==========================================+ Coverage 97.13% 97.17% +0.04%========================================== Files 15 16 +1 Lines 1223 1241 +18 ==========================================+ Hits 1188 1206 +18 Misses 35 35
Continue to review full report at Codecov.
|
It looks like you should update your local repository. |
README.md Outdated
| [Dmitry Ivanov](https://github.com/funbringer) <d.ivanov(at)postgrespro.ru> Postgres Professional Ltd., Russia | ||
| [Ildus Kurbangaliev](https://github.com/ildus) <i.kurbangaliev(at)postgrespro.ru> Postgres Professional Ltd., Russia | ||
| [Yury Zhuravlev](https://github.com/stalkerg) <stalkerg(at)gmail.com> | ||
| [Ildar Musin](https://github.com/zilder) <i.musin(at)postgrespro.ru> Postgres Professional Ltd., Russia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
These lines should end with two spaces, or else the whole paragraph will look awful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me, but README.md has to be fixed.
README.md Outdated
| [Dmitry Ivanov](https://github.com/funbringer) <d.ivanov(at)postgrespro.ru> Postgres Professional Ltd., Russia | ||
| [Ildus Kurbangaliev](https://github.com/ildus) <i.kurbangaliev(at)postgrespro.ru> Postgres Professional Ltd., Russia | ||
| [Yury Zhuravlev](https://github.com/stalkerg) <stalkerg(at)gmail.com> | ||
| [Ildar Musin](https://github.com/zilder) <i.musin(at)postgrespro.ru> Postgres Professional Ltd., Russia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Better not to touch here, these spaces at the end have special meaning for github markdown, without them all these lines will not be on separate lines. Anyway this change isn't related with enums :)
simplified enums NodeStatus and IsolationLevel and add new enum for xlog_method for backup.