- Notifications
You must be signed in to change notification settings - Fork36
Usage of external testgres.os_ops and testgres.common#289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
dmitry-lipetsk merged 27 commits intopostgrespro:masterfromdmitry-lipetsk:D20250816_001--external_os_ops_v001Nov 13, 2025
Merged
Usage of external testgres.os_ops and testgres.common#289
dmitry-lipetsk merged 27 commits intopostgrespro:masterfromdmitry-lipetsk:D20250816_001--external_os_ops_v001Nov 13, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Minimal changes.pg_probackup2 was not changed [I think, it is broken now].
src/operations is deleted.TestgresException, ExecUtilException, InvalidOperationException are gotten from testgres.operations.exceptions
It was deleted by mistake.
b7c33b0 to5b6f451Compare91f1c4c toe7dc9f3Compare---It seems Sphinx does not support our new project structure.So we will process an installed "instance" of testgres but not its source code.
It was restored from hell when we merged with master (postgrespro#290)
6cc9d3b to4219763Compare| fromtestgresimportget_bin_path | ||
| fromtestgresimportget_pg_config | ||
| fromtestgresimportget_pg_version | ||
| fromsrcimportStartNodeException |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Мы же пакет тестируем. В тестех надо импортировать из пакета
demonolock approved these changesNov 12, 2025
8805cc5 intopostgrespro:master 1 check passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This patch starts using the code from external packages:
I think we will commit parts of this patch separately.
Note
Closes#285