- Notifications
You must be signed in to change notification settings - Fork35
commit=True by default in PostgresNode.execute() and document it.#28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Old default could lead to astonishing "where are my damned rows?" emotions.
codecov-io commentedNov 16, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #28 +/- ##======================================= Coverage 93.79% 93.79% ======================================= Files 4 4 Lines 773 773 ======================================= Hits 725 725 Misses 48 48
Continue to review full report at Codecov.
|
| @@ -962,7 +962,7 @@ def poll_query_until(self, | |||
| raise TimeoutException('Query timeout') | |||
| def execute(self, dbname, query, username=None, commit=False): | |||
| def execute(self, dbname, query, username=None, commit=True): | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@funbringer у меня нет, тем более я всегда делал вручную, без параметра
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Нет таких
Nice one, thanks! |
Old default could lead to astonishing "where are my damned rows?" emotions.