NotificationsYou must be signed in to change notification settings
Fork36
Star150

[#266] OsOperations::build_path is added#273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

dmitry-lipetsk merged 1 commit intopostgrespro:masterfromdmitry-lipetsk:master-fix266--v000--build_path

Jun 25, 2025

Merged

[#266] OsOperations::build_path is added#273

dmitry-lipetsk merged 1 commit intopostgrespro:masterfromdmitry-lipetsk:master-fix266--v000--build_path

Jun 25, 2025

Conversation

Copy link

Collaborator

dmitry-lipetsk commentedJun 25, 2025

This thing must be used instead os.path.join(...).

I decided to use the name "build_path' instead "path_join". If you know the better name for this method, please, let me know. Thanks.

LocalOperations uses os.path.join
RemoteOperations uses posixpath.join

We updated:

utils.get_bin_path2
utils.get_pg_config2
utils.get_pg_version2 (note: new restrictions/asserts are added)
RemoteOperations::find_executable
RemoteOperations::copytree
PostgresNode::logs_dir
PostgresNode::data_dir
PostgresNode::utils_log_file
PostgresNode::pg_log_file
PostgresNode::_create_recovery_conf
PostgresNode::_collect_special_files
PostgresNode::default_conf
PostgresNode::append_conf
PostgresNode::set_auto_conf
PostgresNode::upgrade_from
PostgresNode::_get_bin_path
NodeApp::init
NodeApp::make_simple
cache.cached_initdb
cache.call_initdb
NodeBackup.log_file
NodeBackup.init
NodeBackup._prepare_dir

Patch was tested with probackup2.

[postgrespro#266] OsOperations::build_path is added

3659def

This thing must be used instead os.path.join(...).LocalOperations uses os.path.joinRemoteOperations uses posixpath.joinWe updated: - utils.get_bin_path2 - utils.get_pg_config2 - utils.get_pg_version2 (note: new restrictions/asserts are added) - RemoteOperations::find_executable - RemoteOperations::copytree - PostgresNode::logs_dir - PostgresNode::data_dir - PostgresNode::utils_log_file - PostgresNode::pg_log_file - PostgresNode::_create_recovery_conf - PostgresNode::_collect_special_files - PostgresNode::default_conf - PostgresNode::append_conf - PostgresNode::set_auto_conf - PostgresNode::upgrade_from - PostgresNode::_get_bin_path - NodeApp::__init__ - NodeApp::make_simple - cache.cached_initdb - cache.call_initdb - NodeBackup.log_file - NodeBackup.__init__ - NodeBackup._prepare_dir