NotificationsYou must be signed in to change notification settings
Fork36
Star150

[#235] test_pg_ctl_wait_option detects a port conflict#257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

dmitry-lipetsk merged 2 commits intopostgrespro:masterfromdmitry-lipetsk:master-fix235--v000

May 7, 2025

Merged

[#235] test_pg_ctl_wait_option detects a port conflict#257

dmitry-lipetsk merged 2 commits intopostgrespro:masterfromdmitry-lipetsk:master-fix235--v000

May 7, 2025

Conversation

Copy link

Collaborator

dmitry-lipetsk commentedMay 7, 2025

This commit must fix a problem in test_pg_ctl_wait_option when his PostgreSQL instance conflicts with another one.

For this, we added two new things:

PostgresNodeLogReader
PostgresNodeUtils

PostgresNodeLogReader reads server logs.

PostgresNodeUtils provides an utility to detect a port conflict.

PostgresNode::start also uses these new classes.

dmitry-lipetsk added2 commits

May 7, 2025 16:34

[postgrespro#235] test_pg_ctl_wait_option detects a port conflict

017e5e1

This commit must fix a problem in test_pg_ctl_wait_option when his PostgreSQL instance conflicts with another one.For this, we added two new things: - PostgresNodeLogReader - PostgresNodeUtilsPostgresNodeLogReader reads server logs.PostgresNodeUtils provides an utility to detect a port conflict.PostgresNode::start also uses these new classes.

Comment is corrected

0d38b16