Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[#247] PortManager__Generic uses lock-dirs for reserved ports#255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
dmitry-lipetsk wants to merge9 commits intopostgrespro:master
base:master
Choose a base branch
Loading
fromdmitry-lipetsk:master-fix247--v001
Open
Changes from1 commit
Commits
Show all changes
9 commits
Select commitHold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
PortManager__Generic sends debug messages about its operations.
This idea was taken from PgBouncer tests.
  • Loading branch information
@dmitry-lipetsk
dmitry-lipetsk committedMay 29, 2025
commitd15ecdba09aecb65e117f0aad8b03238ed363684
21 changes: 21 additions & 0 deletionstestgres/impl/port_manager__generic.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@
import threading
import random
import typing
import logging


class PortManager__Generic(PortManager):
Expand DownExpand Up@@ -76,22 +77,29 @@ def reserve_port(self) -> int:

try:
lock_path = self.helper__make_lock_path(port)
__class__.helper__send_debug_msg("Attempting to create lock object {}.", lock_path)
self._os_ops.makedir(lock_path) # raise
except: # noqa: 722
__class__.helper__send_debug_msg("Lock object {} is not created.", lock_path)
continue

assert self._os_ops.path_exists(lock_path)

try:
__class__.helper__send_debug_msg("Lock object {} is created.", lock_path)
self._reserved_ports.add(port)
except: # noqa: 722
assert not (port in self._reserved_ports)
self._os_ops.rmdir(lock_path)
__class__.helper__send_debug_msg("Lock object {} was deleted during processing of failure.", lock_path)
raise

assert port in self._reserved_ports
self._available_ports.discard(port)
assert not (port in self._available_ports)

__class__.helper__send_debug_msg("Port {} is reserved.".format(port))

return port

raise PortForException("Can't select a port.")
Expand All@@ -117,9 +125,22 @@ def release_port(self, number: int) -> None:
assert isinstance(self._os_ops, OsOperations)
assert self._os_ops.path_exists(lock_path)
self._os_ops.rmdir(lock_path)
__class__.helper__send_debug_msg("Lock object {} was deleted.", lock_path)

__class__.helper__send_debug_msg("Port {} is released.", number)
return

@staticmethod
def helper__send_debug_msg(msg_template: str, *args) -> None:
assert msg_template is not None
assert str is not None
assert type(msg_template) == str # noqa: E721
assert type(args) == tuple # noqa: E721
assert msg_template != ""
s = "[port manager] "
s += msg_template.format(*args)
logging.debug(s)

def helper__make_lock_path(self, port_number: int) -> str:
assert type(port_number) == int # noqa: E721
# You have to call the reserve_port at first!
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp