Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[#247] PortManager__Generic uses lock-dirs for reserved ports#255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
dmitry-lipetsk wants to merge24 commits intopostgrespro:master
base:master
Choose a base branch
Loading
fromdmitry-lipetsk:master-fix247--v001

Conversation

dmitry-lipetsk
Copy link
Collaborator

@dmitry-lipetskdmitry-lipetsk commentedMay 6, 2025•
edited
Loading

New structures

  • OsLockObj: base (abstract) class to manage fs-based lock object.

Critical changes

  • utils.bound_ports is removed

Closes#247

- [FIX] A creation of self._log_dir is moved to reserve_port method- Code normalization [copy&paste mistakes]- New asserts are added- New comments are added
@dmitry-lipetsk
Copy link
CollaboratorAuthor

dmitry-lipetsk commentedMay 7, 2025•
edited
Loading

Patch was tested with probackup2.

@dmitry-lipetsk
Copy link
CollaboratorAuthor

dmitry-lipetsk commentedJun 23, 2025•
edited
Loading

У меня сомнения насчет это патча.

Штука полезная, но слишком требовательная к устойчивости тестов - если блокировочные каталоги не удалять, то их потом надо будет чистить руками. Это не критично для одноразовых тестовых машин, но все равно как-то не очень...

Пусть пока повисит.

Можно по умолчанию оставить все как есть, а эту фичу оформить как новый класс.

@demonolock
Copy link
Contributor

Какой новый класс, делали чтобы проблему устранить же. И если и с проблемой живется ок, то может просто не делать вовсе

@dmitry-lipetskdmitry-lipetsk marked this pull request as draftJune 27, 2025 06:55
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@demonolockdemonolockdemonolock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using lock files for port reservation
2 participants
@dmitry-lipetsk@demonolock
[8]ページ先頭
©2009-2025 Movatter.jp