- Notifications
You must be signed in to change notification settings - Fork36
[Refactoring] Default port manager functions now use PortManager__Generic and LocalOperations#251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
dmitry-lipetsk merged 2 commits intopostgrespro:masterfromdmitry-lipetsk:D20250504_004--global_port_manager_is_refactoredMay 5, 2025
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…eric and LocalOperationsThis patch deletes a duplication of port manager code.Now utils.reserve_port and utils.release_port works through _old_port_manager - it is a global instance of PortManager__Generic that uses a global instance of LocalOperations.This commit is a part of work forpostgrespro#247.
CollaboratorAuthor
dmitry-lipetsk commentedMay 4, 2025
PR was tested with probackup2 |
After MT-lock we must to check __class__.sm_single_instance again.Refactoring - PortManager__ThisHost::__new__ is replaced with an explicit PortManager__ThisHost::get_single_instance() - PortManager__ThisHost::__init__ is deleted
a683c65 intopostgrespro:master 1 check failed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This patch deletes a duplication of port manager code.
Now
utils.reserve_portandutils.release_portworks through_old_port_manager- it is a global instance ofPortManager__Genericthat uses a global instance ofLocalOperations.It means that
PortManager__ThisHostworks through instance ofPortManager__Generic.Additional changes
PortManager__ThisHostsingleton is fixed. After MT-lock we must to checksm_single_instanceagain.This commit is a part of work for#247.